Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

[react-form] Fix isChangeEvent null check #1290

Merged
merged 4 commits into from
Feb 25, 2020
Merged

[react-form] Fix isChangeEvent null check #1290

merged 4 commits into from
Feb 25, 2020

Conversation

alanthai
Copy link
Contributor

Description

Fixes #1288

This should allow the ability to set null values in custom fields rather than throw an error

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above

@alanthai alanthai added Type: Bug 🐛 Something isn't working Package: react-form labels Feb 19, 2020
@ghost ghost added the cla-needed label Feb 19, 2020
marutypes
marutypes approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@marutypes marutypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for adding the test / changelog as well! :)

@ghost ghost added the cla-needed label Feb 20, 2020
@ghost ghost removed the cla-needed label Feb 25, 2020
@alanthai alanthai merged commit 8563d82 into master Feb 25, 2020
@carysmills carysmills deployed to beta-test-formatting-12-hr-dates February 26, 2020 19:32 Active
@michenly michenly deleted the react-form-isChangeEvent-fix-null-case branch February 27, 2020 18:59
@michenly michenly temporarily deployed to production February 27, 2020 20:05 Inactive
@helloneele helloneele deployed to test-use-memoized-number-format March 6, 2020 19:25 Active
@TayKangSheng TayKangSheng deployed to expand_locale_support_for_shopify_address March 9, 2020 08:16 Active
@michenly michenly temporarily deployed to gem March 24, 2020 21:43 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marutypes marutypes marutypes approved these changes

@patsissons patsissons Awaiting requested review from patsissons

Assignees
No one assigned
Labels
Package: react-form Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[react-form] Custom fields can't have null value
6 participants
@alanthai @marutypes @michenly @helloneele @TayKangSheng @carysmills