Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Replace route propagator with moved notice #1294

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Replace route propagator with moved notice #1294

merged 1 commit into from
Mar 2, 2020

Conversation

iainmcampbell
Copy link
Contributor

@iainmcampbell iainmcampbell commented Feb 21, 2020 •
edited
Loading

@iainmcampbell iainmcampbell force-pushed the route-propagator-moved branch 2 times, most recently from 14e5627 to 781be2b Compare February 26, 2020 22:58
@iainmcampbell iainmcampbell marked this pull request as ready for review February 26, 2020 22:59
@iainmcampbell iainmcampbell changed the title Add moving notice to route propagator Replace route propagator with moved notice Feb 26, 2020
@vividviolet vividviolet mentioned this pull request Feb 26, 2020
Closed
4 tasks
vividviolet
vividviolet reviewed Feb 26, 2020
View reviewed changes
packages/react-shopify-app-route-propagator/README.md
) : null;
});
```
Documentation is available on [Shopify Developers](https://shopify.dev/tools/app-bridge/react-components/route-propagator).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a 404 error trying to access this page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged the docs PR, sorry, it's still in CI

michenly
michenly approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@michenly michenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 yeahhhhh!

@iainmcampbell iainmcampbell force-pushed the route-propagator-moved branch 2 times, most recently from c858394 to 5979c44 Compare February 27, 2020 21:27
@iainmcampbell iainmcampbell force-pushed the route-propagator-moved branch from 5979c44 to 1ac08ec Compare March 2, 2020 19:27
@iainmcampbell iainmcampbell merged commit 542d2e2 into master Mar 2, 2020
@iainmcampbell iainmcampbell deleted the route-propagator-moved branch March 2, 2020 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vividviolet vividviolet vividviolet left review comments

@marutypes marutypes marutypes approved these changes

@michenly michenly michenly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iainmcampbell @michenly @marutypes @vividviolet