This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
[@shopify/react-testing] Update the jest Matches to support the new @types/jest #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandcote
force-pushed
the
fix_jest_types
branch
from
36ec39d to
6cc62c5
Compare
alexandcote
changed the title
alexandcote
force-pushed
the
fix_jest_types
branch
2 times, most recently
from
51e7097 to
bca8aae
Compare
alexandcote
changed the title
alexandcote
force-pushed
the
fix_jest_types
branch
from
bca8aae to
ad73f62
Compare
alexandcote
force-pushed
the
fix_jest_types
branch
from
ad73f62 to
809d897
Compare
michenly
approved these changes
Feb 24, 2020
5 tasks
This was referenced Aug 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1212
The Matchers type change in the version of
@types/jest@24.0.20.Type of change
I adjust the type of the Matchers according to the new take provided by the last version of
@types/jest.@shopify/react-testing- Major: Fix Matchers type (Need@types/jest>=24.0.20)Checklist