This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
add mocks for Country and Countries response for AF Locale #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CountryService api has updated and allow for all locales supported by ShopifyI18n. For locales that is not supported by CountryDb, CountryService will default to english and return a
LOCALE_UNSUPPORTEDerror with the data in en.Therefore this PR adds more mocks for locales that will return both data in
enwithLOCALE_UNSUPPORTEDerror. This PR is a continuation from #1313. Ensure that the PR is merged before this PR.Context
The context of why this PR is started is to fix https://github.com/Shopify/intl-china#110, and this PR is extracted and part of #1301 because of the need to release multiple packages in order.
Type of change
@shopify/address-mocksMinor: New feature (non-breaking change which adds functionality)Checklist