This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Bump core-js^3.0.0 #1323
Closed
Bump core-js^3.0.0 #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandcote
force-pushed
the
bump_core_js
branch
from
930795b to
b4a3df3
Compare
alexandcote
force-pushed
the
bump_core_js
branch
from
ff26066 to
df15395
Compare
alexandcote
force-pushed
the
bump_core_js
branch
3 times, most recently
from
0ef2f0e to
46482ba
Compare
alexandcote
force-pushed
the
bump_core_js
branch
from
46482ba to
afe6177
Compare
1 task
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
alexandcote
removed
the
stale
alexandcote
force-pushed
the
bump_core_js
branch
from
afe6177 to
aa0cc38
Compare
alexandcote
force-pushed
the
bump_core_js
branch
from
aa0cc38 to
ea9c355
Compare
This was referenced Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1660
This PR is related to https://github.com/Shopify/sewing-kit/pull/2453
Description
Since
sewing-kitis moving tocore-js@^3.0.0, and@babel/polyfillis deprecated we had to make our polyfill package follow.Type of change
Removing
@babel/polyfillin favor ofcore-js@^3.0.0andregenerator-runtime.Removing the
@shopify/polyfill/urlpolyfill since it's now provided bycore-js.@shopify/polyfillMajor: Breaking change, theurlpolyfill doesn't exist anymore. This version needs to be used with at leastsewing-kit@^0.150.0.Checklist