Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Adds useDebouncedValue hook #1354

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Adds useDebouncedValue hook #1354

merged 2 commits into from
Apr 8, 2020

Conversation

arthurgouveia
Copy link
Contributor

Description

Adds a new hook to use debounced values. Here's a use case.

Type of change

  • react-hooks Minor: New feature (non-breaking change which adds functionality)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above

@arthurgouveia arthurgouveia marked this pull request as ready for review April 6, 2020 17:57
tleunen
tleunen reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@tleunen tleunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/react-hooks/src/hooks/debounced.ts Outdated Show resolved Hide resolved
packages/react-hooks/src/hooks/debounced.ts Outdated Show resolved Hide resolved
packages/react-hooks/src/hooks/debounced.ts Outdated Show resolved Hide resolved
@arthurgouveia arthurgouveia force-pushed the debounced-value branch 2 times, most recently from d4771f0 to 99b29ea Compare April 7, 2020 15:50
@arthurgouveia arthurgouveia requested a review from tleunen April 7, 2020 16:15
tleunen
tleunen approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@tleunen tleunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor comments

packages/react-hooks/CHANGELOG.md Show resolved Hide resolved
packages/react-hooks/src/hooks/debounced.ts Outdated Show resolved Hide resolved
@tleunen tleunen requested a review from a team April 7, 2020 18:46
@arthurgouveia arthurgouveia requested a review from tleunen April 7, 2020 19:19
mathieulag
mathieulag approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@mathieulag mathieulag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, this will come in handy for most if not all search text input 👍

@arthurgouveia arthurgouveia merged commit cf6cf98 into master Apr 8, 2020
@arthurgouveia arthurgouveia deleted the debounced-value branch April 8, 2020 15:36
@arthurgouveia arthurgouveia mentioned this pull request Apr 8, 2020
Merged
2 tasks
@ismail-syed ismail-syed requested a deployment to production April 8, 2020 18:45 Abandoned
@ismail-syed ismail-syed temporarily deployed to production April 8, 2020 18:45 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mathieulag mathieulag mathieulag approved these changes

@marutypes marutypes Awaiting requested review from marutypes

@tleunen tleunen Awaiting requested review from tleunen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arthurgouveia @tleunen @mathieulag @ismail-syed