This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
React hooks - add useMedia #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvhama
force-pushed
the
react-hooks/useMedia
branch
from
fe728d1 to
2625d53
Compare
sylvhama
force-pushed
the
react-hooks/useMedia
branch
from
2625d53 to
824bc9d
Compare
qq99
approved these changes
Apr 9, 2020
|
If you want to tophat it, you can use |
carolopolo
approved these changes
Apr 14, 2020
This was referenced Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a new attempt to add a
useMediahook after #1338. This one is inspired from https://github.com/Shopify/web/pull/14306, the code was first made by @qq99 <3When using a design system such as Polaris, you might want to change props values based on a media query instead of doing custom css that could break if the design system changes its implementation. E.g. Imagine I might want to hide a TextField label via its labelHidden prop. This is not meant to replace CSS media queries, it's really meant for specific scenarios.
Type of change
Checklist