Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Update eslint and prettier #1381

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Update eslint and prettier #1381

merged 1 commit into from
Apr 17, 2020

Conversation

vsumner
Copy link
Collaborator

@vsumner vsumner commented Apr 16, 2020

Description

This PR updates eslint and prettier to latest and changes eslint-plugin-shopify to @shopify/eslint-plugin.

Type of change

  • Patch: Bug/ Documentation fix (non-breaking change which fixes an issue or adds documentation)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above

@vsumner vsumner requested a review from a team April 16, 2020 21:29
@vsumner vsumner force-pushed the lint-prettier-update-apr2020 branch from b6a14d8 to 29efa8d Compare April 16, 2020 22:11
Copy link
Contributor

@jgodson jgodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few things that could possibly be de-duped. Looks like theres a lint error too. Otherwise LGTM 👍

yarn.lock Outdated Show resolved Hide resolved
debug "^2.6.9"
pkg-dir "^2.0.0"

eslint-module-utils@^2.4.1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth deduping? Not sure how much it matters here but 2.5 would meet this too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually 2.6.0 the 2.5.0 above is locked because of @shopify/eslint-plugin It will need an update.

yarn.lock Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@vsumner vsumner force-pushed the lint-prettier-update-apr2020 branch from 29efa8d to 2b145fd Compare April 17, 2020 12:53
@vsumner vsumner merged commit 128b43b into master Apr 17, 2020
@vsumner vsumner deleted the lint-prettier-update-apr2020 branch April 17, 2020 13:14
@vsumner vsumner temporarily deployed to production April 20, 2020 17:01 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants