This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Fix an issue with bundle size increased #1518
Merged
+13
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandcote
force-pushed
the
fix_bundle_size_increase
branch
from
6716081 to
c8c3659
Compare
vsumner
approved these changes
Jun 17, 2020
marutypes
approved these changes
Jun 17, 2020
alexandcote
force-pushed
the
fix_bundle_size_increase
branch
2 times, most recently
from
91b4e69 to
78c16ec
Compare
|
can this be merged? i'm going to close https://github.com/Shopify/brochure2/pull/21128 in the meantime |
alexandcote
force-pushed
the
fix_bundle_size_increase
branch
from
78c16ec to
751aa1d
Compare
4 tasks
This was referenced Aug 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had reports that the new version of
@shopify/polyfillsincrease the bundle size by about 20kb. After some investigation, using directly thecore-jsimport was the cause of the issue.Instead of only include the polyfills needed, the new version includes every polyfill.
Type of change
Reverting to the original strategy until we move to
core-js@3Checklist