Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

[React Testing] Update README from toContainHtml to toContainReactHtml #1527

Merged
merged 1 commit into from
Jun 22, 2020
Merged

[React Testing] Update README from toContainHtml to toContainReactHtml #1527

merged 1 commit into from
Jun 22, 2020

Conversation

andrewlo
Copy link
Member

Description

It doesn't seem like there is a matcher called toContainHtml, it seems like this doc is referring to toContainReactHtml

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@andrewlo
[React Testing] Update README from toContainHtml to toContainReactHtml
06b353d 
It doesn't seem like there is a matcher called `toContainHtml`, it seems like this doc is referring to `toContainReactHtml`
@andrewlo andrewlo requested a review from jason-sm June 18, 2020 20:12
jason-sm
jason-sm approved these changes Jun 18, 2020
View reviewed changes
Copy link

@jason-sm jason-sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

image

@andrewlo andrewlo merged commit 06e2ce7 into master Jun 22, 2020
@andrewlo andrewlo deleted the alo/react-testing-readme-toContainReactHtml branch June 22, 2020 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jason-sm jason-sm jason-sm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlo @jason-sm