Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Add missing data to session #1542

Closed
wants to merge 10 commits into from
Closed

Add missing data to session #1542

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e1ef8b6
Add missing data to session
babkenmes Jul 3, 2020
29dd2ef
Fix spacing
babkenmes Jul 3, 2020
fdfe23d
Update create-oauth-callback.ts
babkenmes Jul 3, 2020
691c7e9
Update packages/koa-shopify-auth/src/auth/create-oauth-callback.ts
babkenmes Jul 6, 2020
3c08a26
Merge branch 'master' into patch-1
babkenmes Jul 9, 2020
f755475
Merge branch 'master' into patch-1
babkenmes Jul 10, 2020
8d2a2e8
Update packages/koa-shopify-auth/src/auth/create-oauth-callback.ts
babkenmes Jul 13, 2020
6b6b838
Merge branch 'master' into patch-1
babkenmes Jul 13, 2020
735945e
Merge branch 'master' into patch-1
babkenmes Jul 21, 2020
5797a4b
Merge branch 'master' into patch-1
babkenmes Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/koa-shopify-auth/src/auth/create-oauth-callback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,15 @@ export default function createOAuthCallback(config: AuthConfig) {
}

const accessTokenData = await accessTokenResponse.json();
const {access_token: accessToken} = accessTokenData;

const {access_token: accessToken,
associated_user_scope: associatedUserScope,
associated_user: associatedUser} = accessTokenData;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const {access_token: accessToken,
associated_user_scope: associatedUserScope,
associated_user: associatedUser} = accessTokenData;
const {
access_token: accessToken,
associated_user_scope: associatedUserScope,
associated_user: associatedUser
} = accessTokenData;

I think prettier is looking for something like this. I am not sure why it is only failing on a single version though.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still fails


if (ctx.session) {
ctx.session.shop = shop;
ctx.session.accessToken = accessToken;
ctx.session.associatedUserScope = associatedUserScope;
ctx.session.associatedUser = associatedUser;
}

ctx.state.shopify = {
Expand Down