Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Remove SUPPORTED_LOCALES from address-consts #1562

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Remove SUPPORTED_LOCALES from address-consts #1562

merged 1 commit into from
Jul 27, 2020

Conversation

plentz
Copy link
Contributor

@plentz plentz commented Jul 27, 2020 •
edited
Loading

Description

It was used only in the tests.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@plentz plentz force-pushed the plentz.remove-unused-const branch from d153eb1 to 211bf11 Compare July 27, 2020 02:16
@plentz plentz requested review from marutypes and TayKangSheng July 27, 2020 02:42
@shopify-admins shopify-admins requested a review from a team July 27, 2020 02:42
TayKangSheng
TayKangSheng approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@TayKangSheng TayKangSheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

rafaelxy
rafaelxy approved these changes Jul 27, 2020
View reviewed changes
Copy link

@rafaelxy rafaelxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plentz plentz merged commit 046029b into master Jul 27, 2020
@plentz plentz deleted the plentz.remove-unused-const branch July 27, 2020 12:44
@michenly michenly temporarily deployed to production July 28, 2020 19:21 Inactive
@gmcgibbon gmcgibbon temporarily deployed to gem August 10, 2020 19:08 Inactive
This was referenced Aug 1, 2022
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TayKangSheng TayKangSheng TayKangSheng approved these changes

@rafaelxy rafaelxy rafaelxy approved these changes

@marutypes marutypes Awaiting requested review from marutypes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@plentz @rafaelxy @TayKangSheng @michenly @gmcgibbon