This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Fixed error when using chrome autofill #1578
Merged
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KartheekJavvaji
approved these changes
Aug 11, 2020
ghost
added
the
rishabhdev
approved these changes
Aug 12, 2020
|
@lemonmade I am not finding option to add reviewers.. can you please review this PR |
|
cc/ @Shopify/web-foundations for review |
Closed
2 tasks
gmcgibbon
reviewed
Sep 24, 2020
bhavathi
force-pushed
the
chrome-autfil-fix
branch
3 times, most recently
from
979495d to
ce770b4
Compare
bhavathi
force-pushed
the
chrome-autfil-fix
branch
2 times, most recently
from
ce770b4 to
7ea896e
Compare
gmcgibbon
added a commit
that referenced
this pull request
Oct 14, 2020
This was referenced Aug 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed error when using chrome autofill
Uncaught TypeError: event.getModifierState is not a functionWhen using native autofill feature in Chrome, keydown event is raised but event object is missing getModifierState function and causes this error.
Added an additional check before calling getModifierState.