This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
✨ Add useDelayedCallback hook #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolopolo
force-pushed
the
reactHooks/add-use-delayed-callback
branch
3 times, most recently
from
20bae4c to
420e8d0
Compare
mathieulag
approved these changes
Aug 18, 2020
loic-d
reviewed
Aug 18, 2020
| import {useEffect, useState} from 'react'; | ||
|
|
||
| export function useDelayedCallback(callback: () => void, delay: number) { | ||
| const [timeoutId, setTimeoutId] = useState<ReturnType<typeof setTimeout>>(); |
There was a problem hiding this comment.
ReturnType<typeof setTimeout> 🎉
loic-d
reviewed
Aug 18, 2020
| fakeComponent.unmount(); | ||
|
|
||
| fakeComponent.act(() => { | ||
| clock.tick(delay - 1); |
There was a problem hiding this comment.
Shouldn't this be delay instead of delay - 1?
If you haven't reached the delay the callback shouldn't be called wether the component unmounted or not.
There was a problem hiding this comment.
you're right. we don't even need the clock tbh. just the unmount!
tleunen
approved these changes
Aug 18, 2020
loic-d
reviewed
Aug 18, 2020
carolopolo
force-pushed
the
reactHooks/add-use-delayed-callback
branch
from
420e8d0 to
a28c0fa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
useDelayedCallbackhook to thereact-hookspackage.It's useful for when you want to call a function after a given delay. For example, in
web, we are currently looking to use it to call theonClose()of aModalafter a slight delay, in order to wait for the progress bar to become 100% filled visually. Without the delay, theModalcloses abruptly before the progress bar reaches 100% visually.This PR also introduces minor corrections in
README.mdto fix grammar errors/typos/inconsistent verb tenses.Type of change
Checklist