Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Export StringMapper interface #1655

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Export StringMapper interface #1655

merged 1 commit into from
Oct 21, 2020

Conversation

helloneele
Copy link
Contributor

@helloneele helloneele commented Oct 16, 2020 •
edited
Loading

Description

While adding project references in Web, I ran into this error

app/sections/Products/utilities/validators.ts:25:17 - error TS4058: Return type of exported function has or is using name 'StringMapper' from external module "/app/node_modules/@shopify/react-form-state/dist/validators" but cannot be named.

Type of change

  • @shopify/react-form-state Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@helloneele helloneele force-pushed the react-form-state-export-StringMapper branch from 09d1a7a to 6d60d80 Compare October 16, 2020 15:00
@helloneele helloneele marked this pull request as ready for review October 16, 2020 15:01
@helloneele helloneele force-pushed the react-form-state-export-StringMapper branch 2 times, most recently from 24eedd1 to f07996c Compare October 16, 2020 15:15
@helloneele helloneele requested a review from a team October 16, 2020 16:05
dahukish
dahukish approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@dahukish dahukish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@helloneele helloneele force-pushed the react-form-state-export-StringMapper branch from f07996c to 99ce1e4 Compare October 21, 2020 20:37
@helloneele helloneele merged commit 2997120 into master Oct 21, 2020
@helloneele helloneele deleted the react-form-state-export-StringMapper branch October 21, 2020 21:17
@vsumner vsumner temporarily deployed to production October 26, 2020 20:14 Inactive
@marutypes marutypes temporarily deployed to gem February 8, 2021 15:51 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atesgoral atesgoral atesgoral approved these changes

@dahukish dahukish dahukish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@helloneele @atesgoral @dahukish @vsumner @alexandcote @marutypes