Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Jest require updates #1701

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Jest require updates #1701

merged 3 commits into from
Dec 9, 2020

Conversation

atesgoral
Copy link
Contributor

Description

Updating require.require* calls in tests to jest.require* to help reduce the amount of changes going into #1698.

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@atesgoral atesgoral requested review from ismail-syed and a team December 9, 2020 17:48
@shopify-admins shopify-admins requested a review from a team December 9, 2020 17:48
Copy link
Contributor

@ismail-syed ismail-syed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Once CI is ✅

Copy link
Contributor

@michenly michenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense

@atesgoral atesgoral merged commit f93b2dc into master Dec 9, 2020
@atesgoral atesgoral deleted the jest-require-updates branch December 9, 2020 19:58
@gmcgibbon gmcgibbon temporarily deployed to production December 11, 2020 21:33 Inactive
@marutypes marutypes temporarily deployed to gem February 8, 2021 15:51 Inactive
@ismail-syed ismail-syed deployed to beta-mandatory-extensions March 2, 2021 19:35 Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants