Update typescript to v4.3.5 #1997
Conversation
| interface FormatDateOptions extends Intl.DateTimeFormatOptions { | ||
| hourCycle?: string; | ||
| hourCycle?: 'h11' | 'h12' | 'h23' | 'h24'; |
There was a problem hiding this comment.
This is a stricter type, but the spec says that any value other than these will throw a runtime error so nobody would be calling this code with values other than these anyway.
Because of that I'm pretty happy to say that this is a bugfix rather than a breaking change.
See explosions yourself by running this:
console.log(new Intl.DateTimeFormat('en-US', { timeStyle: 'long', hourCycle:'trash' }).format())| @@ -140,14 +140,14 @@ export default class FormState< | |||
|
|
|||
| // eslint-disable-next-line @shopify/react-prefer-private-members | |||
| public validateForm() { | |||
| return new Promise((resolve) => { | |||
| return new Promise<void>((resolve) => { | |||
There was a problem hiding this comment.
TS now warns if you don't return anything from a promise as it suspects that might be a bug. If that's what you absolutely wanted to do then this is how you say "yes Typescript I really wanted to return nothing from this promise'
| @@ -26,7 +26,7 @@ export const dateStyle = { | |||
| hour: '2-digit', | |||
| minute: '2-digit', | |||
| }, | |||
| }; | |||
| } as const; | |||
There was a problem hiding this comment.
Intl.DateTimeFormat now specifies the various options as a union of exact strings ('short' | 'long' etc) rather than any old strings so make this const so we know the values are those exact strings
packages/dates/CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - `formatDate`'s options object now expects its `hourCycle` value to be `'h11', 'h12', 'h23' or 'h24' rather than an arbitary string. Any other value would have caused an error at runtime, this helps us catch that error at compile time. [[#1997](https://github.com/Shopify/quilt/pull/1997)] |
There was a problem hiding this comment.
| - `formatDate`'s options object now expects its `hourCycle` value to be `'h11', 'h12', 'h23' or 'h24' rather than an arbitary string. Any other value would have caused an error at runtime, this helps us catch that error at compile time. [[#1997](https://github.com/Shopify/quilt/pull/1997)] | |
| - `formatDate`'s options object now expects its `hourCycle` value to be `h11`, `h12`, `h23` or `h24` rather than an arbitary string. Any other value would have caused an error at runtime, this helps us catch that error at compile time. [[#1997](https://github.com/Shopify/quilt/pull/1997)] |
packages/dates/CHANGELOG.md
Outdated
| ### Changed | ||
|
|
||
| - `formatDate`'s options object now expects its `hourCycle` value to be `'h11', 'h12', 'h23' or 'h24' rather than an arbitary string. Any other value would have caused an error at runtime, this helps us catch that error at compile time. [[#1997](https://github.com/Shopify/quilt/pull/1997)] | ||
| - Updated bulid tooling, types are now compiled with TypeScript 4.3. [[#1997](https://github.com/Shopify/quilt/pull/1997)] |
There was a problem hiding this comment.
bulid => build throughout
Description
Keeping up to date. We get some perf improvements with incremental builds, and we can stop emitting and publishing typescript generated js files while keeping incremental build support, which leads to smaller package sizes as we're sending less cruft to npm.
You probably want to review this commit by commit, as most of the files changed are the changelogs which were added in the 3rd commit.
Type of change