This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sewing-kit-next
has been renamed toloom
, and has been moved into theshopify
npm namespace. Code behaviour in the latest packages from the@sewing-kit
namespace is identical to the corresponding package in the@shopify
namespace aside from the binary name, the config file name and the metadata directory.This PR:
@sewing-kit/core
with@shopify/loom
,@sewing-kit/cli
with@shopify/loom-cli
and@sewing-kit/plugin-*
with@shopify/loom-plugin-*
loom
executable instead ofskn
sewing-kit.config.ts
toloom.config.ts
.loom
instead of.sewing-kit
in ignore filesAnnoyingly git's rename detection gets confused by all the renames of short and practically identical per-package loom.config.ts files :(
To Tophat
Confirm every package has a new loom.config.ts file
main
branch into~/projects/quilt
, Runrm -rf .sewing-kit; git clean -f -x packages/*/build; yarn build
to generate a fresh build of main.rm -rf .sewing-kit; git clean -f -x packages/*/build; yarn build
to generate a fresh build of this branchfor PACKAGENAME in $(ls -1 packages) do; diff -ru packages/$PACKAGENAME/build ~/projects/quilt/packages/$PACKAGENAME/build -x '*.tsbuildinfo'
to run diffs of every packages's build output.Type of change
-All: patch
Build output should be identical