Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Update puppeteer and resolve cross-fetch to get node-fetch to 2.6.7 #2149

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Update puppeteer and resolve cross-fetch to get node-fetch to 2.6.7 #2149

merged 2 commits into from
Jan 31, 2022

Conversation

vsumner
Copy link
Collaborator

@vsumner vsumner commented Jan 31, 2022 •
edited
Loading

Description

This PR updates puppeteer and adds a resolution for cross-fetch so node-fetch can be updated to 2.6.7.

GHSA-r683-j2x4-v87g

Fixes (issue #)

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • storybook-a11y-test Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@vsumner vsumner marked this pull request as ready for review January 31, 2022 18:19
@vsumner vsumner requested a review from a team as a code owner January 31, 2022 18:19
@vsumner vsumner requested a review from camd January 31, 2022 18:19
marutypes
marutypes approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@marutypes marutypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dahukish
dahukish approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@dahukish dahukish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vsumner vsumner merged commit 39d594a into main Jan 31, 2022
@vsumner vsumner deleted the node-fetch-2.6.7 branch January 31, 2022 18:27
@shopify-shipit shopify-shipit bot temporarily deployed to production February 1, 2022 03:27 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to ssr-logging February 4, 2022 00:02 Inactive
This was referenced Feb 4, 2022
Closed
Merged
@shopify-shipit shopify-shipit bot temporarily deployed to production-gem June 21, 2022 14:45 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marutypes marutypes marutypes approved these changes

@dahukish dahukish dahukish approved these changes

@camd camd Awaiting requested review from camd camd was automatically assigned from Shopify/admin-web-platform

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsumner @dahukish @marutypes