This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Re-export faker from graphql-fixtures #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows consumers to consume the exact faker instance that we're seeding to ensure that they will be consistent with our package. This makes it easier for consumers to use faker in their filler methods so that they don't need to match our exact version in their dependencies.
2 tasks
shopify-shipit
bot
temporarily deployed
to
fix-deprecated-exports-pattern
shopify-shipit
bot
temporarily deployed
to
a11y_tests_class_improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2154
Allows consumers to consume the exact faker instance that we're seeding to ensure that they will be consistent with our package. This makes it easier for consumers to use faker in their filler methods so that they don't need to match our exact version in their dependencies.
Type of change
graphql-fixturesMinor: New feature (non-breaking change which adds functionality)Checklist