use typescript native types

[m4thieulavoie]

Description

This PR is a first of two steps to get rid of Omit, Arguments, ConstructorArguments and ThenType in favour of their native Typescript counterpart.

Fixes (issue #)

Type of change

• react-async Patch: No impact Omit usage change (non-breaking change which fixes an issue)

• react-form-state Patch: No impact Omit usage change (non-breaking change which fixes an issue)

• react-graphql Patch: No impact Omit usage change (non-breaking change which fixes an issue)

• react-testing Patch: No impact Omit and Arguments usage change (non-breaking change which fixes an issue)

• useful-types Patch: No impact ArgumentAtIndex and FirstArgument change to accept Parameters (non-breaking change which fixes an issue)

• Patch: Bug (non-breaking change which fixes an issue)

• Minor: New feature (non-breaking change which adds functionality)

• Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

[BPScott]

As we're now no longer depending on @shopify/useful-types in several places, we might have packages that no longer depend upon @shopify/useful-types. For instance it looks like that was the only usage in react-form-state.

Can you identify these cases where a package no longer depends upon @shopify/useful-types, and then in those packages remove the dependency from package.json and the tsconfig.json.

[BPScott]

MaybeFunctionReturnType looks very similar to ReturnType, I wonder if that's a meaningful difference, and thus if it's worth removing MaybeFunctionReturnType?

export type MaybeFunctionReturnType<T> = T extends (...args: any[]) => infer U
  ? U
  : never;


type ReturnType<T extends (...args: any) => any> = T extends (...args: any) => infer R ? R : any;

[m4thieulavoie]

As we're now no longer depending on @shopify/useful-types in several places, we might have packages that no longer depend upon @shopify/useful-types. For instance it looks like that was the only usage in react-form-state.

Can you identify these cases where a package no longer depends upon @shopify/useful-types, and then in those packages remove the dependency from package.json and the tsconfig.json.

That's done, but it affected some unit tests. Let me know if I handled that properly!

[m4thieulavoie]

MaybeFunctionReturnType looks very similar to ReturnType, I wonder if that's a meaningful difference, and thus if it's worth removing MaybeFunctionReturnType?

export type MaybeFunctionReturnType<T> = T extends (...args: any[]) => infer U
  ? U
  : never;


type ReturnType<T extends (...args: any) => any> = T extends (...args: any) => infer R ? R : any;

Tried to do it yesterday, but I guess I was tired, but browsing reddit I found exactly what I was missing 😅 that should be done!

[m4thieulavoie]

Gosh I feel dumb now 🤦

[BPScott]

I've pushed a commit that reverts the typescript-project-references.test.ts changes and applies the proper fix.

That test asserts that "if you use a dependency on another package in this monorepo in a package's package.json, then there should be a corresponding entry in that package's tsconfig.json reference field" (as this repo uses project references - one ts project per package)

You've removed react-server's dependency on useful-types in the package.json, but you did not remove the reference to the useful-types folder in react-server's tsconfig.json. And thus the test fails, as there should be mention of a dependant package (or in this case no mention of a package that is not depended upon) in both package.json and tsconfig.json.

The fix is not to modify the typescript-project-references.test.ts, but to update the tsconfig.json files, removing the references to useful-types in the packages that no longer depend upon useful-types

[m4thieulavoie]

I've pushed a commit that reverts the typescript-project-references.test.ts changes and applies the proper fix.

That test asserts that "if you use a dependency on another package in this monorepo in a package's package.json, then there should be a corresponding entry in that package's tsconfig.json reference field" (as this repo uses project references - one ts project per package)

You've removed react-server's dependency on useful-types in the package.json, but you did not remove the reference to the useful-types folder in react-server's tsconfig.json. And thus the test fails, as there should be mention of a dependant package (or in this case no mention of a package that is not depended upon) in both package.json and tsconfig.json.

The fix is not to modify the typescript-project-references.test.ts, but to update the tsconfig.json files, removing the references to useful-types in the packages that no longer depend upon useful-types

Nice! I totally missed that packages had internal tsconfig.json, that's my bad!

[BPScott]

Just pushed up another commit where I spotted dangling usages of FirstArgument and Arguments.

• Packages that no longer depend upon useful-types should have an entry in their CHANGELOG.md. Remember to reference this PR, like the other changelog entries
• I reckon we can revert the change in useful-types - we're due to delete these types once we update this PR anyway so I don't think there's much value in adjusting them now.

[BPScott]

If the plan is to remove Argument, ArgumentAtIndex and FirstArgument imminently then do we need to make this change now?

I'd be tempted to revert this, and the change to packages/useful-types/CHANGELOG.md

[m4thieulavoie]

Agreed, just reverted it

[BPScott]

Code changes look good to me.

Can you add changelog entries to the packages that no longer depend upon useful-types

[BPScott]

This can be removed, as we're no longer touching useful-types

[m4thieulavoie]

Done

[BPScott]

Updated the changelog entries to use the "changed" subheading and add the link to the PR