Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Update wildcard exports in package.json #2209

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Update wildcard exports in package.json #2209

merged 4 commits into from
Mar 9, 2022

Conversation

vsumner
Copy link
Collaborator

@vsumner vsumner commented Mar 9, 2022

Description

Bug fix for:

Module not found: Error: Expecting file to file mapping. "./" should not end with "/"

Fixes (issue #)

Type of change

All packages get a patch update as this is a bug fix.

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@vsumner vsumner marked this pull request as ready for review March 9, 2022 16:21
@vsumner vsumner requested a review from a team as a code owner March 9, 2022 16:21
@vsumner vsumner requested a review from dahukish March 9, 2022 16:21
@vsumner vsumner mentioned this pull request Mar 9, 2022
1 task
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This follows https://nodejs.org/api/packages.html#package-entry-points

As a last resort, package encapsulation can be disabled entirely by creating an export for the root of the package "./": "./"

@vsumner vsumner merged commit 0299454 into main Mar 9, 2022
@vsumner vsumner deleted the fix-wildcard-export branch March 9, 2022 16:33
@shopify-shipit shopify-shipit bot temporarily deployed to production March 9, 2022 16:42 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to apollo-3-test March 15, 2022 18:42 Inactive
@shopify-shipit shopify-shipit bot had a problem deploying to storybook-a11y-async-load-stories April 1, 2022 12:52 Failure
@shopify-shipit shopify-shipit bot had a problem deploying to storybook-a11y-async-load-stories April 1, 2022 13:08 Failure
@shopify-shipit shopify-shipit bot temporarily deployed to storybook-a11y-async-load-stories April 1, 2022 13:25 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to mf-beta April 5, 2022 07:48 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to mock-factory-beta April 5, 2022 12:29 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to beta-js April 5, 2022 14:54 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production-gem June 21, 2022 14:45 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants