This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Allow waitUntil param to take options #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emiryy
changed the title
|
/snapit |
|
🫰✨ Thanks @emiryy! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/mime-types@0.0.0-snapshot-20220822163423yarn add @shopify/react-graphql@0.0.0-snapshot-20220822163423yarn add @shopify/react-graphql-universal-provider@0.0.0-snapshot-20220822163423yarn add @shopify/storybook-a11y-test@0.0.0-snapshot-20220822163423 |
emiryy
force-pushed
the
a11y-wait-until
branch
from
97bb33e to
0d9702e
Compare
CameronGorrie
approved these changes
Aug 22, 2022
BPScott
reviewed
Aug 22, 2022
There was a problem hiding this comment.
Code looks good!
Remember to add documentation for this in the readme
emiryy
force-pushed
the
a11y-wait-until
branch
from
51a6cc1 to
96cffc5
Compare
BPScott
approved these changes
Aug 23, 2022
emiryy
commented
Aug 23, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of https://github.com/Shopify/web/issues/70453
Current flakiness of accessibility tests is due to network requests taking a long time and most of the time we test a loading state (which passes), but in reality, there is an actual error or violation on the fully complete state that the we only sometimes test (which ends up failing).
This PR allows for the
waitUntilparameter to take in different options so that we can set it differently in web.