This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Update typescript to v4.7 #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
commented
Sep 6, 2022
| @@ -1,7 +1,7 @@ | |||
| import {set} from './utilities'; | |||
|
|
|||
| export interface NavigatorWithConnection extends Navigator { | |||
| connection: { | |||
| connection: Navigator['connection'] & { | |||
There was a problem hiding this comment.
As of TS 4.4 the connection key now exists on Navigator, so extend from that and mock out the keys that are required because of this.
| // According to the spec the max value timeRemaining can return is 50 | ||
| const MAX_TIME_REMAINING = 50; | ||
|
|
||
| function fallbackQueueingFunction(cb: IdleCallback) { | ||
| function fallbackQueueingFunction(cb: IdleRequestCallback) { |
There was a problem hiding this comment.
As of TS 4.4 requestIdleCallback and cancelIdleCallback keys exist on TS's definition of Window so we don't need to augment it here anymore.
|
|
||
| extendedWindow.cancelIdleCallback = | ||
| extendedWindow.cancelIdleCallback || (window as any).clearImmediate; | ||
| export {}; |
There was a problem hiding this comment.
This file no longer contains an import so we need something to tell TS/babel "this file is authored in the esmodules style"
ryanwilsonperkin
approved these changes
Sep 6, 2022
royleejr
approved these changes
Sep 6, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update typescript to v4.7.4.
useUnknownInCatchVariables: falseto override strict mode. Enabling this new strict mode option (which would be the case because we setstrict:true) causes lots of errors. On order to focus on the update, let's disable it for now and we can go back to fixing this up as part of Enable tsconfig strict mode options #1815.