This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Enable importsNotUsedAsValues:error and use import type where possible #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
importsnotusedasvalues
branch
2 times, most recently
from
2460f4f to
b45ac31
Compare
BPScott
force-pushed
the
importsnotusedasvalues
branch
from
b45ac31 to
505d679
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove our override for the
importsNotUsedAsValuestypescript option, which causes it to use the value from the strictest config -error.Adjust imports of types to use
import typewhere required.