This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
[react-testing] Fixed a null exception if the inner root component is unmounted by the outer wrapper during an act #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @melnikov-s! Your snapshot has been published to npm. Test the snapshot by updating your yarn add @shopify/react-testing@0.0.0-snapshot-20230323202007 |
melnikov-s
force-pushed
the
react-testing-do-not-throw-on-unmount
branch
from
ebd1faa to
928a344
Compare
|
/snapit |
|
🫰✨ Thanks @melnikov-s! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/koa-metrics@0.0.0-snapshot-20230324134013yarn add @shopify/koa-performance@0.0.0-snapshot-20230324134013yarn add @shopify/react-testing@0.0.0-snapshot-20230324134013yarn add @shopify/statsd@0.0.0-snapshot-20230324134013 |
ryanwilsonperkin
approved these changes
Mar 24, 2023
… unmounted by the outer wrapper during an act
melnikov-s
force-pushed
the
react-testing-do-not-throw-on-unmount
branch
from
928a344 to
2fd6bbe
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an edge-case that was introduced in #1821
This is a rare occurrence but can happen if somehow the test wrapper unmounts the inner test root during an action. We found this while performing the react router 6 migration on
web. Since we wrap our inner test root with a<Route>component at a given path a navigation within the test to a different route will unmount the component resulting in a cryptic error message:TypeError: Cannot use 'in' operator to search for '_reactInternalFiber' in nullThis PR prevents the root from updating when the inner wrapper is unmounted, once/if it is remounted subsequent updates will work as expected.