This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
[@shopify/graphql-testing] upgrade @apollo/client and add props to GraphQL class #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbann
force-pushed
the
mb/update/graphql-testing-factory
branch
from
872f2bc to
7982395
Compare
markbann
changed the title
markbann
force-pushed
the
mb/update/graphql-testing-factory
branch
4 times, most recently
from
ac1d1bf to
38fb7a9
Compare
markbann
force-pushed
the
mb/update/graphql-testing-factory
branch
from
38fb7a9 to
cc41cf9
Compare
gcorne
reviewed
Feb 26, 2024
| @@ -31,7 +31,7 @@ | |||
| "node": "^14.17.0 || >=16.0.0" | |||
| }, | |||
| "dependencies": { | |||
| "@apollo/client": "^3.5.8", | |||
| "@apollo/client": "^3.8.10", | |||
There was a problem hiding this comment.
Not sure how web platform folks feel, but I think using peerDependencies for @apollo/client may be the way to go so that apps have more freedom to upgrade when they see fit.
There was a problem hiding this comment.
That makes sense to me. I was worried about potential side effects of updating this. I think peerDependencies makes takes away some risk.
markbann
force-pushed
the
mb/update/graphql-testing-factory
branch
3 times, most recently
from
c25c7b2 to
4876647
Compare
emiryy
approved these changes
Feb 27, 2024
vsumner
reviewed
Feb 28, 2024
| "graphql": ">=14.5.0 <16.0.0", | ||
| "jest-matcher-utils": "^26.6.2" | ||
| }, | ||
| "devDependencies": { | ||
| "graphql-typed": "^2.0.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "@apollo/client": ">=3.5.8 || <3.9.0" |
There was a problem hiding this comment.
I'm a bit curious as to the <3.9.0. Why not <4.0.0? apollo is at 3.9.5 why wouldn't we want to support further?
There was a problem hiding this comment.
I haven't tested with 3.9.x so I didn't want to go too high. That said, I think it's reasonable to include everything up to the next major version.
vsumner
approved these changes
Feb 28, 2024
markbann
force-pushed
the
mb/update/graphql-testing-factory
branch
from
4876647 to
db7367f
Compare
markbann
force-pushed
the
mb/update/graphql-testing-factory
branch
from
db7367f to
a224c11
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of https://github.com/Shopify/banking-client/issues/2257
Summary
We faced a few different problems while attempting to integrate this library into the banking-client.
ApolloClientin theGraphQLinstance attempting to connect to dev tools by defaultconnectToDevTools: falseingraphql-controller.tserrorPolicyof ApolloClient usesnoneby defaultcreateGraphQLFactoryto include an optionaldefaultOptions@apollo/clientQuestion
Should this be a major version bump due to the
@apollo/clientupgrade?I chose minor when making the changeset since I don't think the optional param or
connectToDevTools: falsewith break anything, but consumers on lower versions of@apollo/clientwill be forced to upgrade.