This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Use act from 'react' #2773
Merged
Use act from 'react' #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @jas7457! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/address": "0.0.0-snapshot-20240506151112",
"@shopify/react-testing": "0.0.0-snapshot-20240506151112" |
|
Testing in the Discovery App: Here are all of our tests passing with this change, using React 18.3.1: Here are all of our tests passing with this change, using React 18.2.0: Here is what we see when we run the code in 18.2.0: Here is what we see when we run the code in 18.3.1: |
|
/snapit |
|
🫰✨ Thanks @jas7457! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/address": "0.0.0-snapshot-20240506154147",
"@shopify/react-testing": "0.0.0-snapshot-20240506154147" |
melnikov-s
approved these changes
May 6, 2024
Merged
brendo
reviewed
May 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In React 18.3, they have deprecated
actfromreact-dom/test-utilsand instead export it directly fromreact. To help with backwards compatibility, we can use it fromreactif the repo has >18.3.1 and fallback otherwise.