This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Make useMedia options an optional param #2811
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkubej
approved these changes
Jul 16, 2024
vividviolet
reviewed
Jul 17, 2024
.changeset/orange-rabbits-juggle.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@shopify/react-hooks': minor | |||
There was a problem hiding this comment.
ah maybe. Though it already got released due to a bad push to an unprotected main branch https://www.npmjs.com/package/@shopify/react-hooks
Keeping it as-is to avoid version issues
There was a problem hiding this comment.
Even if the minor has been released when this PR goes in it will just do a patch bump so there shouldn't be an issue I don't think.
melnikov-s
force-pushed
the
use-media-optional-options
branch
3 times, most recently
from
6e088dd to
5f54bce
Compare
vsumner
approved these changes
Jul 17, 2024
emiryy
approved these changes
Jul 17, 2024
melnikov-s
force-pushed
the
use-media-optional-options
branch
from
5f54bce to
a7b810b
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes (issue #)
Makes the options parameter to
useMediabe optional as intended