Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Update formatName and abbreviateName to return a string or undefined #2844

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

trishrempel
Copy link
Contributor

@trishrempel trishrempel commented Jan 8, 2025

Description

This PR updates the formatName (and through dependency abbreviateName) to return string | undefined rather than a blank string if any of the provided inputs do not yield a valid non-empty value.

Already merged in https://github.com/Shopify/quilt-internal/pull/31

@trishrempel trishrempel requested a review from a team as a code owner January 8, 2025 14:41
@shopify-shipitnext
Copy link

🔎 View this PR in Shipit Next.

ℹ️ Expand to learn how to deploy and handle emergencies using Shipit Next

Overview

Shipit Next will merge your code on your behalf because this repository uses Shipit Next and its merge queue.

To ship this PR, you can either:

Comment Commands

  • /shipit: Enqueue this PR into the merge queue where it will eventually be merged and deployed.
  • /cancel: Eject this PR from the merge queue and rebuild PRs that were enqueued after this PR.
  • /shipit --jump-queue: Enqueue this PR at the top of the merge queue where it will be included in the next deploy. Use this for non-emergency situations.
    - Emergency handling procedure for this command can be found here.
  • /shipit --emergency: Merge this PR directly into main and deploy to all environments once all require_for_emergency CI checks pass. Please be aware that changes deployed with this command will not be automatically rolled back.

Commands exclusive to Deploy Before Merge

  • /cancel --emergency: Eject this PR from the merge and rollback any deployments containing this PR.

Documentation

Questions or feedback?

@trishrempel trishrempel self-assigned this Jan 8, 2025
@trishrempel
Copy link
Contributor Author

/snapit

Copy link
Contributor

github-actions bot commented Jan 8, 2025

🫰✨ Thanks @trishrempel! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/name": "0.0.0-snapshot-20250108144406",
"@shopify/react-i18n": "0.0.0-snapshot-20250108144406",
"@shopify/react-i18n-universal-provider": "0.0.0-snapshot-20250108144406"

@trishrempel trishrempel force-pushed the react-i18n/name-return-undefined branch from 3282fcf to f9084dc Compare January 8, 2025 14:44
@trishrempel
Copy link
Contributor Author

/snapit

Copy link
Contributor

github-actions bot commented Jan 8, 2025

🫰✨ Thanks @trishrempel! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/name": "0.0.0-snapshot-20250108150133",
"@shopify/react-i18n": "0.0.0-snapshot-20250108150133",
"@shopify/react-i18n-universal-provider": "0.0.0-snapshot-20250108150133"

Copy link
Contributor

@jesstelford jesstelford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jesstelford jesstelford merged commit c294df9 into main Jan 10, 2025
5 checks passed
@jesstelford jesstelford deleted the react-i18n/name-return-undefined branch January 10, 2025 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants