This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
React upgrade 16.9 #688
Merged
React upgrade 16.9 #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
force-pushed
the
react-upgrade-16.9
branch
14 times, most recently
from
09568e3 to
3175af5
Compare
lemonmade
suggested changes
May 9, 2019
| if (returnValue instanceof Promise) { | ||
| return returnValue.then(ret => { | ||
| if (isPromise(returnValue)) { | ||
| return Promise.resolve(promise as Promise<any>).then(ret => { |
There was a problem hiding this comment.
Should leave a comment of why you check that returnValue is a promise, not promise
|
|
||
| return result; | ||
| if (isPromise(result)) { | ||
| return Promise.resolve(promise).then(afterResolve) as any; |
There was a problem hiding this comment.
Same request as above re: clarifying comments for this and the type casting of act above
marutypes
approved these changes
May 9, 2019
cartogram
force-pushed
the
react-upgrade-16.9
branch
4 times, most recently
from
88cdc45 to
281f33c
Compare
cartogram
force-pushed
the
react-upgrade-16.9
branch
from
281f33c to
54a4850
Compare
lemonmade
approved these changes
May 9, 2019
| .find('button', {type: 'submit'})! | ||
| .trigger('onClick', clickEvent()); | ||
| wrapper.act(() => { | ||
| wrapper |
There was a problem hiding this comment.
I don't think you should need to wrap this in an act?
There was a problem hiding this comment.
Removing fails the test actually. It can't find the element.
| .find('button', {type: 'submit'})! | ||
| .trigger('onClick', clickEvent()); | ||
| wrapper.act(() => { | ||
| wrapper |
There was a problem hiding this comment.
Same, same as above.
| importRemote.act(() => { | ||
| requestIdleCallback.runIdleCallbacks(); | ||
| await importRemote.act(async () => { | ||
| await requestIdleCallback.runIdleCallbacks(); |
There was a problem hiding this comment.
We should be able to await on the result of calling load instead then?
cartogram
force-pushed
the
react-upgrade-16.9
branch
from
54a4850 to
ed3a5b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull closes https://github.com/Shopify/web/issues/13363 by upgrading to React@16.9.0.alpha0, this includes:
reactandreact-dom(note, there are no tags for the updated types yet)react-testinglibrary🎩 There should be no failing tests, no async-act related skipped tests and no act-related console errors.