This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Universal Cookies #935
Closed
Universal Cookies #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
commented
Aug 30, 2019
marutypes
suggested changes
Aug 30, 2019
There was a problem hiding this comment.
I don't hate the idea of handling cookies holistically from in this package, but I'd rather we leveraged https://www.npmjs.com/package/universal-cookie / https://www.npmjs.com/package/universal-cookie-koa like we do in web rather than rebuilding it's functionality.
| } | ||
|
|
||
| // eslint-disable-next-line no-warning-comments | ||
| // TODO: Add a watcher function that reapplies the cookies |
There was a problem hiding this comment.
If we just used https://www.npmjs.com/package/universal-cookie it would handle updating the cookies for us
lemonmade
reviewed
Aug 30, 2019
cartogram
force-pushed
the
universal-cookies
branch
2 times, most recently
from
fb3aae9 to
f179ebb
Compare
cartogram
force-pushed
the
universal-cookies
branch
from
f179ebb to
ec3ca75
Compare
|
superseding by #1002 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logic around setting and getting cookies to
react-network.Question: Should we have a separate package for this (
@shopify/universal-cookies)? At first I felt like cookies fell into the "network" side of things, but on the other hand, they also live in the browser.I also need to figure out a way to keep the cookie headers on the server in sync with changes (see comment here. One way I was thinking would be that there is a way to attach a change watcher on the cookies during the
applyToContextstep. The cookies setter would then call the watcher every time cookies change. This pushes me further in the direction of this being outside of thereact-networkpackage.Type of change
react-networkMinor: New feature (non-breaking change which adds functionality)Checklist