Add activestorage.rbi #108
+29
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -24,6 +24,16 @@ | |||||||||||||||||||
| "active_record" | ||||||||||||||||||||
| ] | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| "activestorage": { | ||||||||||||||||||||
| "dependencies": [ | ||||||||||||||||||||
| "rails" | ||||||||||||||||||||
| ], | ||||||||||||||||||||
| "requires": [ | ||||||||||||||||||||
| "rails", | ||||||||||||||||||||
|
Comment on lines
+28
to
+32
There was a problem hiding this comment. My previous comment was not correct, this work locally without upstream changes:
Suggested change
Rails contains a single file and dependencies on all gems (including Railties), Railties has what we actually need. |
||||||||||||||||||||
| "active_storage/engine", | ||||||||||||||||||||
| "active_storage" | ||||||||||||||||||||
| ] | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| "activesupport": { | ||||||||||||||||||||
| "requires": [ | ||||||||||||||||||||
| "active_support", | ||||||||||||||||||||
|
|
||||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # typed: strict | ||
|
|
||
| class ActiveStorage::Attached::One | ||
| # @shim: Methods on Attached::One are delegated to `ActiveStorage::Blob` through `ActiveStorage::Attachment` using `method_missing` | ||
| include ActiveStorage::Blob::Analyzable | ||
| # @shim: Methods on Attached::One are delegated to `ActiveStorage::Blob` through `ActiveStorage::Attachment` using `method_missing` | ||
| include ActiveStorage::Blob::Identifiable | ||
| # @shim: Methods on Attached::One are delegated to `ActiveStorage::Blob` through `ActiveStorage::Attachment` using `method_missing` | ||
| include ActiveStorage::Blob::Representable | ||
| end | ||
|
|
||
| class ActiveStorage::Attached::Many | ||
| # @shim: Methods on Attached::Many are delegated to `ActiveStorage::Blob` through `ActiveStorage::Attachment` using `method_missing` | ||
| include ActiveStorage::Blob::Analyzable | ||
| # @shim: Methods on Attached::Many are delegated to `ActiveStorage::Blob` through `ActiveStorage::Attachment` using `method_missing` | ||
| include ActiveStorage::Blob::Identifiable | ||
| # @shim: Methods on Attached::Many are delegated to `ActiveStorage::Blob` through `ActiveStorage::Attachment` using `method_missing` | ||
| include ActiveStorage::Blob::Representable | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it fail without
railsdependency and require?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not. Active Storage doesn't depend on Rails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since ActiveStorage::Blob/ActiveStorage::Attachment are technically models, it needs to load the ActiveStorage engine, and the engine failed to load until rails was added as a dependency. Is there a smaller dependency I can use to get the engine to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem seems to be there is a
require "rails"dependency in ActiveStorage, but it's not declared as a dependency in the gemspec. Same goes for Action Cable, Action Mailbox and Action Text.