Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Prism requirement to v0.20 #263

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Upgrade Prism requirement to v0.20 #263

merged 4 commits into from
Feb 5, 2024

Conversation

vinistock
Copy link
Member

Upgrading to the latest Prism, so that we can unblock the same in the Ruby LSP.

There were only two corrections:

  1. A value is no longer nilable and so the T.must became unnecessary
  2. The error messages changed, so I updated our expectations

@vinistock vinistock self-assigned this Feb 5, 2024
@vinistock vinistock requested a review from a team as a code owner February 5, 2024 14:49
@vinistock vinistock merged commit e1e4d45 into main Feb 5, 2024
8 checks passed
@vinistock vinistock deleted the vs/upgrade_prism_requirement branch February 5, 2024 15:29
@Morriar Morriar added the dependencies Pull requests that update a dependency file label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

@egiurleo egiurleo Awaiting requested review from egiurleo egiurleo is a code owner automatically assigned from Shopify/sorbet

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan is a code owner automatically assigned from Shopify/sorbet

Assignees

@vinistock vinistock

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinistock @st0012 @Morriar