Introduce Type builder interface
#331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
force-pushed
the
at-type-builder
branch
2 times, most recently
from
049dd0c to
3dac103
Compare
This interface is used to manually build RBI types. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com> Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
paracycle
approved these changes
Jul 31, 2024
| @@ -586,7 +586,7 @@ def add_block_param(name) | |||
| end | |||
| def add_sig( | |||
| params: [], | |||
| return_type: nil, | |||
| return_type: "void", | |||
There was a problem hiding this comment.
Should this also be Type.void like below?
| @@ -839,7 +839,7 @@ def visit_call_node(node) | |||
| end | |||
| end | |||
| when "void" | |||
| @current.return_type = nil | |||
| @current.return_type = "void" | |||
There was a problem hiding this comment.
Again, maybe this should be Type.void? Or do want to wait for the Type parser to make that change?
There was a problem hiding this comment.
Yeah I should have changed all of them to "void" for now
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com> Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface let the user create RBI types manually:
On top of providing more safety with static typing, the interface will apply some sanity rules to what the user builds to avoid common mistakes when generating RBIs:
The interface will also take care of simplifying some unnecessary complex types:
This PR changes the
Modelclasses to allow passing either Strings or Types to relevant classes such asSig,SigParamorTStruct.cc. @paracycle