Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a few missing test for Type builder interface #337

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add a few missing test for Type builder interface #337

merged 1 commit into from
Aug 5, 2024

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Aug 2, 2024

Automated dead code analysis detected a few candidates:

These methods are part of the public API and should be properly tested.

@Morriar
Add a few missing test for Type builder interface
ab84076 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the chore Chore task label Aug 2, 2024
@Morriar Morriar self-assigned this Aug 2, 2024
@Morriar Morriar requested a review from a team as a code owner August 2, 2024 14:01
@Morriar Morriar requested review from egiurleo and KaanOzkan August 2, 2024 14:01
@Morriar Morriar merged commit 90eb9f4 into main Aug 5, 2024
8 checks passed
@Morriar Morriar deleted the at-add-type-tests branch August 5, 2024 22:20
@amomchilov
Copy link
Contributor

Should I close #334 now that this is shipped? @Morriar

@amomchilov amomchilov mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

@egiurleo egiurleo egiurleo approved these changes

Assignees

@Morriar Morriar

Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Morriar @amomchilov @egiurleo @KaanOzkan