Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix using flawed useQuery hook from @apollo/client #4

Merged
merged 1 commit into from
May 12, 2022

Conversation

ElviraBurchik
Copy link
Contributor

Description

#545 broke queries in the fixture app. The latest version of @apollo/client has a bug where the useQuery loading state stays true after fetch finishes - #6334, so when #545 replaced deprecated @apollo/react-hooks with @apollo/client, and the issue became prominent.

Screenshot 2022-05-06 at 16 37 14

Suggested solution to the problem is to downgrade @apollo/client for now, this PR fixes the problem.

Reviewers’ hat-rack 🎩

Checklist

  • I have added a decision record entry, PR includes changes to monorepo setup that may require explanation
  • I have added a changelog entry following the Keep a Changelog guidelines.

@ElviraBurchik ElviraBurchik requested a review from fortmarek May 6, 2022 16:28
@ElviraBurchik ElviraBurchik self-assigned this May 6, 2022
@caution-tape-bot
Copy link

👋 It looks like you're updating JavaScript packages that are known
to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

If running these commands doesn't produce a change in your yarn.lock file,
you didn't have duplications in these packages and can carry on.

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their
default context values. Multiple versions of such packages will yield
multiple global instances, resulting in oblique runtime errors.

@ElviraBurchik ElviraBurchik merged commit 2c4b979 into main May 12, 2022
@ElviraBurchik ElviraBurchik deleted the chore/fix-fixture-queries branch May 17, 2022 13:42
@shopify-shipit shopify-shipit bot temporarily deployed to production June 2, 2022 10:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants