Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

innerRef on canvas component for animations #188

Closed
ChrisJamesC opened this issue Feb 9, 2022 · 1 comment
Closed

innerRef on canvas component for animations #188

ChrisJamesC opened this issue Feb 9, 2022 · 1 comment

Comments

@ChrisJamesC
Copy link
Contributor

ChrisJamesC commented Feb 9, 2022 •
edited
Loading

When using the reanimated page of the documentation, it is mentioned that we need to use innerRef on the canvas component.

This seems to lead to 2 issues:

  1. This property doesn't exist on the Canvas component
  2. The app craches because useSharedValueEffect gets a null ref and doesn't know how to handle that

Changing innerRef to ref changes the 2 issues in my codebase.

Please let me know if you'd like me to create a PR to fix the 2 issues mentioned above.

This is probably a regression since this issue appeared when I upgraded from 0.1.80 to 0.1.103
ChrisJamesC added a commit to ChrisJamesC/react-native-skia that referenced this issue Feb 9, 2022
@ChrisJamesC
Fix Shopify#188: Update reanimated docs for refs
76b2ea3
@ChrisJamesC ChrisJamesC mentioned this issue Feb 9, 2022
Closed
@wcandillon
Copy link
Contributor

fixed by #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update reanimated docs for refs ChrisJamesC/react-native-skia
2 participants
@wcandillon @ChrisJamesC