Fix bug in Coons Patches + API alignement + Example #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrfalch
reviewed
Feb 2, 2022
| @@ -3,7 +3,7 @@ import { StyleSheet, View } from "react-native"; | |||
|
|
|||
| import { HomeScreenButton } from "./HomeScreenButton"; | |||
|
|
|||
| export const HomeScreen: React.FC = () => { | |||
| export const HomeScreen = () => { | |||
There was a problem hiding this comment.
Just a note: I like using React.FC in component declarations since they enforce a few extra things like the return value of the function being correct. We'll go without it for now - just wanted to mention it.
chrfalch
approved these changes
Feb 2, 2022
| @@ -122,8 +122,8 @@ namespace RNSkia | |||
| // verify size of input uniforms | |||
| if (jsiUniformsSize * sizeof(float) != getObject()->uniformSize()) | |||
| { | |||
| jsi::detail::throwJSError( | |||
| runtime, "Uniforms size differs from effect's uniform size."); | |||
| std::string msg = "Uniforms size differs from effect's uniform size. Received " + std::to_string(jsiUniformsSize) + " expected " + std::to_string(getObject()->uniformSize() / sizeof(float)); | |||
There was a problem hiding this comment.
Long line - should have some line breaks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a serious bug in the order of the points we were providing to Skia.
The API has been updated to be more symmetric with the Vertices API.
In terms of the parameters to provide, there are many we could do there and I am up to discussing them.
We can potentially provide support for different input shapes.
The current API requires you to think of a Coons Patch as 4 cornes with 2 cubic Bezier handle per corner.
In the use case of the example (with movable handles), it works seamlessly. There might be some other use cases where an input of a different shape makes sense, (when given curves directly for instance). We could definitely provide some utility functions there.