Feature/skia m99 #165
Merged
Feature/skia m99 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added use of xcframeworks to be able to package archs and platforms correctly - Fixed build in Skia iOS to correctly build for arc and platform - Updated configuration with more flexible setup and typed structs. - Removed android aar build script
- Added README update for upgrading Skia
- Releasing NPM packages are now manually triggered - Building SKIA is now manually triggered.
wcandillon
approved these changes
Feb 2, 2022
|
@ChrisJamesC this enables RN Skia to run on arm64 simulator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After meeting with Google we decided to try to stay on the latest Skia release at all times. In addition we have a few outstanding issues with running on the Apple iOS M1 Simulator in Xcode that we want to address. We also don't emit bitcode for the device builds on iOS - this is also addressed.
fixes #161
fixes #47
fixes #35