Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false exit when yarn warning #1912

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix false exit when yarn warning #1912

merged 2 commits into from
Oct 31, 2023

Conversation

hans00
Copy link
Contributor

@hans00 hans00 commented Oct 12, 2023

The yarn warning warning ../../package.json: No license field will make build fail

@wcandillon
Copy link
Contributor

This looks ok, the goal of this PR is to fix the yarn bootstrap command if we run it with a warning like the ../../package.json: No license field one?

@wcandillon
Copy link
Contributor

@hans00 closing as I'm confused by the goal of this PR but if you can provide more context, I would be happy to review it/merge it

@wcandillon wcandillon closed this Oct 31, 2023
@hans00
Copy link
Contributor Author

hans00 commented Oct 31, 2023

This looks ok, the goal of this PR is to fix the yarn bootstrap command if we run it with a warning like the ../../package.json: No license field one?

This fix yarn build-skia (also build-skia-android and build-skia-ios)
that because the script runs yarn and the yarn will output No license field on stderr

`yarn ts-node ./scripts/build-skia.ts android ${targetKey}`;

@wcandillon wcandillon reopened this Oct 31, 2023
@wcandillon
Copy link
Contributor

@hans00 I tried it and it seems to work as expected thks

@wcandillon wcandillon self-requested a review October 31, 2023 11:46
@wcandillon wcandillon merged commit 31d092d into Shopify:main Oct 31, 2023
1 check passed
@hans00 hans00 deleted the fix-build branch October 31, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants