Fix font memory issues #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could probably also cherry-pick the velocity bug fix as well as the loop yoyo fix. |
chrfalch
suggested changes
Mar 1, 2022
| : JsiSkWrappingSkPtrHostObject(context, contourMeasure){}; | ||
| const sk_sp<SkContourMeasure> contourMeasure) | ||
| : JsiSkWrappingSkPtrHostObject(context, contourMeasure) { | ||
| assert(contourMeasure != nullptr); |
There was a problem hiding this comment.
Shouldn't we throw a JS error - this assert will just make the app unexpectedly quit?
There was a problem hiding this comment.
Thankfully the only call to this constructor checks for null pointer. but update the code to throw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from the animation branch