Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Shadows #217

Merged
merged 14 commits into from
Mar 4, 2022
Merged

Drop Shadows #217

merged 14 commits into from
Mar 4, 2022

Conversation

wcandillon
Copy link
Contributor

@wcandillon wcandillon commented Mar 3, 2022 •
edited
Loading

No description provided.

@wcandillon wcandillon requested a review from chrfalch March 3, 2022 11:55
@wcandillon wcandillon self-assigned this Mar 3, 2022
chrfalch
chrfalch reviewed Mar 3, 2022
View reviewed changes
example/src/App.tsx Outdated Show resolved Hide resolved
chrfalch
chrfalch suggested changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments :)

@wcandillon
Copy link
Contributor Author

wcandillon commented Mar 3, 2022 •
edited
Loading

Implemented review comments 🙌🏼

@wcandillon wcandillon requested a review from chrfalch March 3, 2022 21:02
chrfalch
chrfalch suggested changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few missing/wrong isUndefined() / isNull() :)

@wcandillon wcandillon requested a review from chrfalch March 4, 2022 11:20
@wcandillon
Copy link
Contributor Author

Should be good now 👍🏻

chrfalch
chrfalch approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcandillon wcandillon merged commit f15ca2f into main Mar 4, 2022
@wcandillon wcandillon deleted the feat/shadows branch March 14, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch chrfalch approved these changes

Assignees

@wcandillon wcandillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcandillon @chrfalch