fix: Fix ThreadSkiaMetalContext being re-created at times
#2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`number` is always double, which does not have the same integer precision as uint64_t/bigint/uintptr_t.
mrousavy
changed the base branch from
main
to
feat/make-image-from-platform-buffer
mrousavy
changed the base branch from
feat/make-image-from-platform-buffer
to
main
|
super nice, testing it now |
wcandillon
reviewed
Apr 10, 2024
| id<MTLCommandQueue> commandQueue = nullptr; | ||
| sk_sp<GrDirectContext> skContext = nullptr; | ||
| }; | ||
|
|
||
| class ThreadContextHolder { | ||
| public: | ||
| static thread_local SkiaMetalContext ThreadSkiaMetalContext; | ||
| static const std::unique_ptr<SkiaMetalContext>& getThreadSpecificSkiaContext(); |
There was a problem hiding this comment.
this doesn't appear to fix the issue for me.
My test scenario is different as I create offscreen surfaces before testing the platform buffers (so I initialize things you might not have on your side).
Also if there is a change to be made here, should be done as a standalone change first?
|
closing for now after offline discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
ThreadContextHolder::ThreadSkiaMetalContexttoThreadContextHolder::getThreadSpecificSkiaContext()which is safer and fixes a bug in #2344 where I couldn't use the GPU texture.Note: This PR is based on #2344.