Test detection of packaged fonts #2512
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, packaged fonts are included in the font manager on iOS but are missing on Android. This is documented in #2503. In response to a request in that issue, I'm putting up this draft PR with a demonstration of the issue in the
exampleproject. I've updated the example to have the Roboto font packaged with the app and added a test confirming that it is detected and usable in Skia. This test passes on iOS but fails on Android. I haven't been able to get the example app running on Android due to compile errors in the build process, however I know that on Android the test will fail since I've done the same test with my private app.