Fix typo jlong -> jdouble for seek method of the Video (android only) #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wcandillon let's merge this and create a next version, as this is the critical fix. |
|
signed the Contributor License Agreement (CLA) just in case |
wcandillon
approved these changes
Jul 25, 2024
|
thanks a lot :) |
|
🎉 This issue has been resolved in version 1.3.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@wcandillon thank YOU! also found one more issue, making a PR :) |
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2531
In java native part, the seek method got double parameter instead of long, but in cpp part, the casting wan't changed, what caused the issue of incorrect value.