Fix Android threading issue #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
🎉 This PR is included in version 1.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-skia
that referenced
this pull request
Dec 21, 2024
Every offscreen surfaces where sharing the OpenGL context even though they may be created from different thread. This can easily cause crashes, especially in viewRef.makeImageSnapshot which is using an offscreen surface. We sanitized the OpenGLContext to not have anything shared across threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every offscreen surfaces share the same root context even though they can be created from different thread.
This can easily cause crashes, especially in
viewRef.makeImageSnapshotwhich is using an offscreen surface.We also suspect that because onscreen surfaces are using the parent context where all the offscreen surfaces are created with, it may also cause some error.
We also took advantage of the issue to make a refactoring of the OpenGL logic.