Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix app not starting due to deadlock in installBindings #31

Closed
wants to merge 1 commit into from
Closed

fix: Fix app not starting due to deadlock in installBindings #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package/cpp/rnskia/RNSkManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void RNSkManager::installBindings() {
// when accessing the javascript objects from a thread not being the JS
// thread. On Android this is actually necessary, since we need to set up the
// API before the javascript starts to execute!
#ifndef ANDROID
#ifdef ANDROID
std::mutex mu;
std::condition_variable cond;

Expand All @@ -68,7 +68,7 @@ void RNSkManager::installBindings() {
*_jsRuntime, "SkiaViewApi",
jsi::Object::createFromHostObject(*_jsRuntime, _viewApi));

#ifndef ANDROID
#ifdef ANDROID
isInstalled = true;
cond.notify_one();
});
Expand Down