Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix gradle 7 error #43

Closed
wants to merge 11 commits into from
Closed

Conversation

Andarius
Copy link

@Andarius Andarius commented Dec 18, 2021

This PR is my attempt to fix #41.
For now it fails with

Execution failed for task ':externalNativeBuildDebug'.
> Build command failed.
  Error while executing process /home/Android/Sdk/cmake/3.10.2.4988404/bin/ninja with arguments {-C /home/Projects/react-native-skia/package/android/.cxx/cmake/debug/armeabi-v7a reactskia}
  ninja: Entering directory `/home/Projects/react-native-skia/package/android/.cxx/cmake/debug/armeabi-v7a'
  [1/6] Building CXX object CMakeFiles/reactskia.dir/cpp/jni/JniPlatformContext.cpp.o
  [2/6] Building CXX object CMakeFiles/reactskia.dir/cpp/jni/JniLoad.cpp.o
  [3/6] Building CXX object CMakeFiles/reactskia.dir/cpp/rnskia/RNSkManager.cpp.o
  FAILED: CMakeFiles/reactskia.dir/cpp/rnskia/RNSkManager.cpp.o 
  /home/Android/Sdk/ndk/21.4.7075529/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ --target=armv7-none-linux-androideabi16 --gcc-toolchain=/home/Android/Sdk/ndk/21.4.7075529/toolchains/llvm/prebuilt/linux-x86_64 --sysroot=/home/Android/Sdk/ndk/21.4.7075529/toolchains/llvm/prebuilt/linux-x86_64/sysroot  -Dreactskia_EXPORTS -I../../../../../node_modules/react-native/ReactCommon/callinvoker -I../../../../../node_modules/react-native/ReactCommon/jsi -I../../../../../node_modules/react-native/ReactCommon/react/nativemodule/core -I../../../../../node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni -I../../../../../../../react-native/ReactCommon/callinvoker -I../../../../../../../react-native/ReactCommon/jsi -I../../../../../../../react-native/ReactCommon/react/nativemodule/core -I../../../../../../../react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni -I../../../../cpp/skia/include/config -I../../../../cpp/skia/include/core -I../../../../cpp/skia/include/effects -I../../../../cpp/skia/include/utils -I../../../../cpp/skia/include/pathops -I../../../../cpp/skia/modules -I../../../../cpp/skia/include -I../../../../cpp/skia -I../../../../cpp/api -I../../../../cpp/jsi -I../../../../cpp/jni/include -I../../../../cpp/rnskia -I../../../../cpp/utils -I../../../../build/fbjni-0.2.2-headers.jar -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -march=armv7-a -mthumb -Wformat -Werror=format-security  -fexceptions -frtti -std=c++1y -DONANDROID -DSK_GL -DSK_BUILD_FOR_ANDROID -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_HAVE_MEMRCHR=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DON_ANDROID -DONANDROID -O0 -fno-limit-debug-info  -fPIC   -std=gnu++1z -MD -MT CMakeFiles/reactskia.dir/cpp/rnskia/RNSkManager.cpp.o -MF CMakeFiles/reactskia.dir/cpp/rnskia/RNSkManager.cpp.o.d -o CMakeFiles/reactskia.dir/cpp/rnskia/RNSkManager.cpp.o -c ../../../../cpp/rnskia/RNSkManager.cpp
  In file included from ../../../../cpp/rnskia/RNSkManager.cpp:3:
  In file included from ../../../../cpp/api/JsiSkApi.h:7:
  ../../../../cpp/api/JsiSkRuntimeEffect.h:75:55: error: no member named 'size' in 'SkRuntimeEffect::ConstIterable<SkRuntimeEffect::Uniform>'
        return static_cast<int>(getObject()->uniforms().size());
                                ~~~~~~~~~~~~~~~~~~~~~~~ ^
  1 error generated.
  [4/6] Building CXX object CMakeFiles/reactskia.dir/cpp/jni/JniSkiaDrawView.cpp.o
  [5/6] Building CXX object CMakeFiles/reactskia.dir/cpp/jni/JniSkiaManager.cpp.o
  ninja: build stopped: subcommand failed.

@ghost ghost added the cla-needed label Dec 18, 2021
@ghost ghost removed the cla-needed label Dec 18, 2021
@Andarius Andarius changed the title trying to fix gradle 7 error WIP: fix gradle 7 error Dec 18, 2021
@Andarius Andarius closed this Jan 12, 2022
@Andarius Andarius reopened this Feb 2, 2022
@ghost ghost added the cla-needed label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with gradle 7
1 participant