Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a github workflow to test pull requests #96

Merged
merged 4 commits into from
Feb 3, 2022

Conversation

ChrisJamesC
Copy link
Contributor

For now we only lint typescript code.

@wcandillon wcandillon requested a review from chrfalch January 10, 2022 10:56
@wcandillon wcandillon self-requested a review January 10, 2022 10:56
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested locally.

@wcandillon
Copy link
Contributor

@ChrisJamesC This is great thank you 🙌🏼

Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrfalch
Copy link
Contributor

chrfalch commented Feb 2, 2022

@ChrisJamesC Thanks for creating the PR!! I'm seeing some issues when running this workflow:

https://github.com/Shopify/react-native-skia/runs/5033854401?check_suite_focus=true

Could you see if there is something missing?

@ChrisJamesC
Copy link
Contributor Author

@chrfalch thanks for checking.
Since the workflow still needs approval, could you please check if my change fixed the run ?
Thanks a lot!

@ChrisJamesC
Copy link
Contributor Author

Thanks for the approval.

It passes now. We can still discuss if you would like to regroup common dependencies (eslint, react) in the parent package or keep importing them at the 3 different places. Or we can move on with this, since it works for now.

@chrfalch
Copy link
Contributor

chrfalch commented Feb 3, 2022

Thanks for the approval.

It passes now. We can still discuss if you would like to regroup common dependencies (eslint, react) in the parent package or keep importing them at the 3 different places. Or we can move on with this, since it works for now.

We'll merge it since it works for now :) :) Thanks so much!!

@chrfalch chrfalch merged commit b203a98 into Shopify:main Feb 3, 2022
@chrfalch chrfalch mentioned this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants