-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a github workflow to test pull requests #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested locally.
@ChrisJamesC This is great thank you 🙌🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisJamesC Thanks for creating the PR!! I'm seeing some issues when running this workflow: https://github.com/Shopify/react-native-skia/runs/5033854401?check_suite_focus=true Could you see if there is something missing? |
@chrfalch thanks for checking. |
Thanks for the approval. It passes now. We can still discuss if you would like to regroup common dependencies (eslint, react) in the parent package or keep importing them at the 3 different places. Or we can move on with this, since it works for now. |
We'll merge it since it works for now :) :) Thanks so much!! |
For now we only lint typescript code.